Skip to content

Conversation

@majorosdonat
Copy link
Contributor

If and edge worker is shut down and removed, it is not cleared from the database. Therefore it will be visible on the edge worker hosts page for ever, even if it is not used anymore, making the worker list longer and harder to read.
This PR adds an option to the UI to delete that worker from the database.
Also, proper csrf handling is added to the maintenance mode as fix.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the provider:edge Edge Executor / Worker (AIP-69) / edge3 label Feb 5, 2025
@majorosdonat majorosdonat marked this pull request as ready for review February 5, 2025 07:04
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing CSRF

@eladkal eladkal changed the title Implement worker deletion and proper scrf handling Implement worker deletion and proper CSRF handling Feb 5, 2025
@jscheffl jscheffl merged commit 6059e84 into apache:main Feb 5, 2025
71 of 90 checks passed
insomnes pushed a commit to insomnes/airflow that referenced this pull request Feb 6, 2025
Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com>
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com>
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:edge Edge Executor / Worker (AIP-69) / edge3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants