Skip to content

Conversation

@jcrobak
Copy link
Contributor

@jcrobak jcrobak commented Feb 5, 2025

Adds support for passing through the ocsp_fail_open parameter. Ref: https://docs.snowflake.com/en/developer-guide/python-connector/python-connector-connect#choosing-fail-open-or-fail-close-mode

The ocsp_fail_open parameter defaults to True inside of the driver when the snowflake-connector version is 1.8.0 or later. So the usual case for overriding the setting will be providing a False value. That is different than other flags (where we only pass through True), so you may notice some difference in the flag handling.

Also, for building the sqlalchemy engine, this parameter needs to be passed in as part of connect_args.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the provider:snowflake Issues related to Snowflake provider label Feb 5, 2025
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 5, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

For sqlalchemy, this needs to be passed in as part of connect_args.
@jcrobak jcrobak force-pushed the snowflake-ocsp-fail-open-setting branch from 439b039 to d4a7d71 Compare February 5, 2025 20:52
@jcrobak
Copy link
Contributor Author

jcrobak commented Feb 5, 2025

Thanks for the review @potiuk !! The build failed with:

The image /mnt/ci-image-save-linux_amd64-3.9.tar does not exist.

during the "Prepare breeze & CI Image: 3.9" step of Lowest direct dependency providers tests / All-core:LowestDeps-Postgres:13:3.9.

I don't think this is related to this change, so I have rebased to see if it can pick up any fixes for main. Do you mind kicking off the CI again?

@potiuk potiuk merged commit 7e9b9ed into apache:main Feb 5, 2025
61 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 5, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

insomnes pushed a commit to insomnes/airflow that referenced this pull request Feb 6, 2025
For sqlalchemy, this needs to be passed in as part of connect_args.
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
For sqlalchemy, this needs to be passed in as part of connect_args.
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
For sqlalchemy, this needs to be passed in as part of connect_args.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:snowflake Issues related to Snowflake provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants