Fix scheduler ServiceAccount automount for multi-executor #46486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't just check if CeleryExecutor is one of the executors when determining if we can expose the automount param, we need to make sure it's the _only_ executor - the others need it.
jedcunningham
requested review from
dstandish and
hussein-awala
as code owners
romsharon98
approved these changes
Feb 5, 2025
hussein-awala
approved these changes
Feb 5, 2025
potiuk
approved these changes
Feb 5, 2025
eladkal
approved these changes
Feb 5, 2025
insomnes
pushed a commit
to insomnes/airflow
that referenced
this pull request
Feb 6, 2025
We can't just check if CeleryExecutor is one of the executors when determining if we can expose the automount param, we need to make sure it's the _only_ executor - the others need it.
insomnes
pushed a commit
to insomnes/airflow
that referenced
this pull request
Feb 6, 2025
We can't just check if CeleryExecutor is one of the executors when determining if we can expose the automount param, we need to make sure it's the _only_ executor - the others need it.
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
We can't just check if CeleryExecutor is one of the executors when determining if we can expose the automount param, we need to make sure it's the _only_ executor - the others need it.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
We can't just check if CeleryExecutor is one of the executors when determining if we can expose the automount param, we need to make sure it's the _only_ executor - the others need it.
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't just check if CeleryExecutor is one of the executors when determining if we can expose the automount param, we need to make sure it's the only executor - the others need it.