Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Feb 6, 2025

Why

#46194

What

  • Add triggered_by to task_sdk DagRun
  • Not adding data_interval_start, data_interval_end, prev_data_interval_start_success, prev_data_interval_end_success, logical_date, ds, ds_nodash, ts, ts_nodash, ts_nodash_with_tz keys to context if it's a triggered_by asset

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@uranusjr
Copy link
Member

uranusjr commented Feb 6, 2025

It’s not mentioned in the linked issue, but in other issues there’s a rule saying if logical date is not available, data interval should not be either. It’s probably not a bad idea to do them both in one PR.

@Lee-W Lee-W force-pushed the forbid-logical-date-access-for-asset-triggered-dag branch from 823b31a to e63d0a8 Compare February 7, 2025 09:46
@Lee-W
Copy link
Member Author

Lee-W commented Feb 7, 2025

It’s not mentioned in the linked issue, but in other issues there’s a rule saying if logical date is not available, data interval should not be either. It’s probably not a bad idea to do them both in one PR.

Removed the following keys data_interval_start, data_interval_end, prev_data_interval_start_success, prev_data_interval_end_success, logical_date, ds, ds_nodash, ts, ts_nodash, ts_nodash_with_tz. Is there anything missed or shouldn't be removed?

@Lee-W Lee-W force-pushed the forbid-logical-date-access-for-asset-triggered-dag branch 3 times, most recently from 2398b39 to 5b47c3f Compare February 7, 2025 10:43
@Lee-W Lee-W force-pushed the forbid-logical-date-access-for-asset-triggered-dag branch from 5b47c3f to 916ed61 Compare February 8, 2025 05:14
@Lee-W Lee-W force-pushed the forbid-logical-date-access-for-asset-triggered-dag branch from 916ed61 to 9aa8da9 Compare February 8, 2025 06:05
@Lee-W Lee-W added the AIP-83 Remove Execution Date Unique Constraint from DAG Run label Feb 10, 2025
@Lee-W
Copy link
Member Author

Lee-W commented Feb 11, 2025

suppressed by #46460

@Lee-W Lee-W closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AIP-83 Remove Execution Date Unique Constraint from DAG Run area:task-sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants