AIP-83 refactor backfill reprocess behaviour #46554
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for reprocess behaviour
…tor-backfill-reprocess-behaviour
…com:astronomer/airflow into AIP83-refactor-backfill-reprocess-behaviour
dstandish
reviewed
Feb 12, 2025
dstandish
reviewed
Feb 12, 2025
dstandish
reviewed
Feb 12, 2025
dstandish
reviewed
Feb 12, 2025
dstandish
reviewed
Feb 12, 2025
dstandish
reviewed
Feb 12, 2025
…grun would not be executed
…com:astronomer/airflow into AIP83-refactor-backfill-reprocess-behaviour
dstandish
added a commit
that referenced
this pull request
Feb 23, 2025
There were some issues in the logic that needed to be resolved. Some of them were unset variables in the exception block, but the main issue was re the need to clear a dag run when the log date is there. Replaces #46554 Closes #46278 Also resolves comment thread https://github.com/apache/airflow/pull/46248/files#r1952725320.
Contributor
|
obsoleted by #46959 |
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
There were some issues in the logic that needed to be resolved. Some of them were unset variables in the exception block, but the main issue was re the need to clear a dag run when the log date is there. Replaces apache#46554 Closes apache#46278 Also resolves comment thread https://github.com/apache/airflow/pull/46248/files#r1952725320.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #46278
AIP-83: Restore Uniqueness Constraint on Logical Date, Make It Nullable impacted backfill reprocessing behavior. Now, attempting to reprocess a run with the same logical date results in a unique constraint error.
This PR fixes that behavior by clearing the existing run before reprocessing, restoring the legacy behavior instead of creating a new run.
Now we are not getting Unique constraint if reprocess behaviour is
completedorfailedIn
backfill_dag_runtable as run would be cleared and would be inqueuedstate. We will add exception reason asin flight^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.