Migrate Amazon provider package #46590
Conversation
potiuk
requested review from
ashb,
bolkedebruin,
eladkal,
jedcunningham and
o-nikolas
as code owners
boring-cyborg
bot
added
area:dev-tools
area:providers
kind:documentation
provider:amazon
|
cc: @o-nikolas -> could not add fixup in your PR so created a new one (but you are author still) :) |
potiuk
force-pushed
the
migrante_ampp
branch
3 times, most recently
from
ddb0879 to
3116fc7
Compare
o-nikolas
left a comment
o-nikolas
left a comment
There was a problem hiding this comment.
Thanks for taking this one across the line! I was hoping to get it done on Friday, but a looot of things broke so it was taking a while. Amazon is used quite a bit in a lot of core tests as well which is interesting.
The build looks green, but please do have a look at my commits in #46498 to ensure they're correct, otherwise lgtm 👍
|
Yeah. I took it from your PR initially and added some fixes :) |
Fixes: apache#46045 Co-authored-by: Niko Oliveira <onikolas@amazon.com>
Sad that it merged as your commit, because I spent a lot of time on it 😅, but thanks again for taking it across the line! |
|
🎉 |
Well. Not really. I am very careful about those of not to remove the original author We are both co-authors of that merged commit: 
|
Fixes: apache#46045 Co-authored-by: Niko Oliveira <onikolas@amazon.com>
4 participants
Fixes: #46045
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.