Skip to content

Conversation

@sunank200
Copy link
Collaborator

@sunank200 sunank200 commented Feb 10, 2025

The PR #43902 renames the execution_date column to logical_date in the log table as well, apart from the dag run table. But this PR missed the migration file for log table changes.

This PR adds a migration file to update the log table by renaming the execution_date column to logical_date. The column remains nullable.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@sunank200 sunank200 requested review from ashb and uranusjr February 10, 2025 20:19
@sunank200 sunank200 self-assigned this Feb 10, 2025
@sunank200 sunank200 added the AIP-83 Remove Execution Date Unique Constraint from DAG Run label Feb 10, 2025
@ashb
Copy link
Member

ashb commented Feb 10, 2025

image I think GitHub is having a moment

@sunank200 sunank200 marked this pull request as ready for review February 10, 2025 20:37
@sunank200 sunank200 force-pushed the migration_rename_log_fix branch from d79ccc3 to 0296eba Compare February 11, 2025 04:09
Copy link
Contributor

@vatsrahul1001 vatsrahul1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@Lee-W Lee-W merged commit 06c9a98 into apache:main Feb 11, 2025
45 checks passed
@Lee-W Lee-W deleted the migration_rename_log_fix branch February 11, 2025 06:04
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
…log table (apache#46634)

* add missing migration for renaming execution_date to logical_date to log table

* Update airflow/migrations/versions/0032_3_0_0_rename_execution_date_to_logical_date_and_nullable.py

* fix static check

---------

Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AIP-83 Remove Execution Date Unique Constraint from DAG Run area:db-migrations PRs with DB migration kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants