Always clean airflow installation in provider's compatibility tests #46693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far cleaning airflow installation only happened in canary runs and it caused some PRs not failing when they should - for exmaple the apache#45294 was green when it should fail because uuid6 package was not removed before installing old version of Airlfow. Cleaning airflow installation is fast with uv so we should be ok with running it always for compatibility tests.
potiuk
force-pushed
the
use-clean-airflow-installation-in-all-compat-test
branch
from
17023bd to
a89bc85
Compare
mobuchowski
approved these changes
Feb 12, 2025
ashb
approved these changes
Feb 12, 2025
Member
Author
|
Failing tests are unrelated (and likely fixed in main soon or already :). |
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…pache#46693) So far cleaning airflow installation only happened in canary runs and it caused some PRs not failing when they should - for exmaple the apache#45294 was green when it should fail because uuid6 package was not removed before installing old version of Airlfow. Cleaning airflow installation is fast with uv so we should be ok with running it always for compatibility tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far cleaning airflow installation only happened in canary runs and it caused some PRs not failing when they should - for exmaple the #45294 was green when it should fail because uuid6 package was not removed before installing old version of Airlfow.
Cleaning airflow installation is fast with uv so we should be ok with running it always for compatibility tests.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.