Fix exists method to support using Requester Pays
#46759
Conversation
boring-cyborg
bot
added
the
provider:google
kylase
force-pushed
the
gcs_exists_user_project
branch
2 times, most recently
from
3ce9ea9 to
65bc5e3
Compare
kylase
force-pushed
the
gcs_exists_user_project
branch
from
65bc5e3 to
bcbfab3
Compare
|
@potiuk, how do I get a reviewer or who can I reach out to review this PR? I notice that the |
|
Hi! I see that you have added unit test, but can you please provide here a screenshot of successfully executed system test for this logic? Thanks! |
I am not sure if people run those :) -> but @kylase -> maybe you can? It's not difficult -> https://github.com/apache/airflow/blob/main/contributing-docs/testing/system_tests.rst |
|
I did run the system tests prior to submitting a PR. Sorry, I have been busy these days, so I wasn't able to respond. I will provide a screenshot by next week. |
|
No need in this case - we trust you :) |
|
@potiuk and @VladaZakharova, sorry for the delay. 
|
* Fix `exists` method to support using Requester Pays * Fix wrong type for user_project * Revert change for _get_blob --------- Co-authored-by: Yuan Chuan Kee <1683885+kylase@users.noreply.github.com>
3 participants
existsmethod to supportuser_projectfor Requester Paysrelated: #32760
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.