[v2-10-test] Don't resolve path for DAGs folder #46877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
added
the
full tests needed
jedcunningham
changed the title
potiuk
approved these changes
Feb 20, 2025
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
This breaks our handling of deleted DAG files. We don't need to have the resolved absolute path - symlinks are fine and actually what we want!
sunank200
force-pushed
the
fix_symlink_resolving_for_dagdir
branch
from
ee87dfc to
78b8d8e
Compare
amoghrajesh
approved these changes
May 8, 2025
uranusjr
approved these changes
May 8, 2025
phanikumv
approved these changes
May 8, 2025
vatsrahul1001
approved these changes
May 8, 2025
kaxil
pushed a commit
that referenced
this pull request
May 8, 2025
(cherry picked from commit b157d1f)
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With gitsync, the DAGs folder is a symlink,
repo -> {commit}. In our DAG processor, when we clean up stale DAGs, we compare processor_subdir here to make sure we are only cleaning up "our" DAG files - but the db record has the resolved path, not the one with the symlink because we resolve it here.I don't think we really need the resolved path - the one that matches the dags_folder config is better for us generally.
Fair warning, there is some history of bugs in this area, see #41433, #42111, but I believe this change is right and won't have any negative side effects.