Skip to content

Conversation

@insomnes
Copy link
Contributor


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the provider:cncf-kubernetes Kubernetes (k8s) provider related issues label Feb 21, 2025
@insomnes
Copy link
Contributor Author

insomnes commented Feb 21, 2025

As a side-node: I have a strong feeling that the image field is wrongly documented and typed, it's required by pod spec, and will not run with a None value, but I didn't test this hypothesis.

@insomnes insomnes changed the title Update templated fields in KPO doc-string + wording KubernetesPodOperator doc-string update templated fields + wording Feb 21, 2025
@potiuk
Copy link
Member

potiuk commented Feb 22, 2025

As a side-node: I have a strong feeling that the image field is wrongly documented and typed, it's required by pod spec, and will not run with a None value, but I didn't test this hypothesis.

Not sure either. But I am not very worrried - (though if someone would like to check it that woudl be cool).

@potiuk potiuk merged commit 18582eb into apache:main Feb 22, 2025
72 checks passed
@insomnes insomnes deleted the kpo-name-template-doc-str branch March 8, 2025 17:06
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants