Pool name shouldn't be updated via pool PATCH API call #46986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamraj-git
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
jason810496
reviewed
Feb 24, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Should we add a test case for the Invalid body, pool name from request body doesn't match uri parameter bad request scenario?
pierrejeambrun
approved these changes
Feb 24, 2025
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Looking good, just a few nits.
1 task
pierrejeambrun
approved these changes
Feb 25, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 28, 2025
* Pool name shouldn't be updated * Add tests and no name can go with update_mask
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* Pool name shouldn't be updated * Add tests and no name can go with update_mask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not let the Pool name update. We should follow the similar behaviour as we do it for variables, connections.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.