-
Notifications
You must be signed in to change notification settings - Fork 16.4k
AIP-72: Moving BaseOperatorLink to task sdk #47008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
amoghrajesh
merged 40 commits into
apache:main
from
astronomer:AIP72-baseoperatorlink-to-sdk
Mar 7, 2025
Merged
AIP-72: Moving BaseOperatorLink to task sdk #47008
amoghrajesh
merged 40 commits into
apache:main
from
astronomer:AIP72-baseoperatorlink-to-sdk
Mar 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Feb 24, 2025
ashb
reviewed
Feb 24, 2025
providers/google/src/airflow/providers/google/cloud/links/base.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Finally got a green run on this one! |
ashb
approved these changes
Mar 4, 2025
Member
ashb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, a few nits/small changes. Pre-approving once those are done
ashb
reviewed
Mar 6, 2025
providers/amazon/src/airflow/providers/amazon/aws/links/base_aws.py
Outdated
Show resolved
Hide resolved
providers/databricks/src/airflow/providers/databricks/operators/databricks.py
Outdated
Show resolved
Hide resolved
providers/databricks/src/airflow/providers/databricks/plugins/databricks_workflow.py
Outdated
Show resolved
Hide resolved
providers/dbt/cloud/src/airflow/providers/dbt/cloud/operators/dbt.py
Outdated
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/links/base.py
Outdated
Show resolved
Hide resolved
providers/microsoft/azure/src/airflow/providers/microsoft/azure/operators/powerbi.py
Outdated
Show resolved
Hide resolved
providers/microsoft/azure/src/airflow/providers/microsoft/azure/operators/synapse.py
Outdated
Show resolved
Hide resolved
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py
Outdated
Show resolved
Hide resolved
providers/standard/src/airflow/providers/standard/sensors/external_task.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Damn this will need a rebase now! |
Contributor
Author
|
Just rebased it, will wait for the CI and merge :) |
1 task
This was referenced Mar 10, 2025
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:CLI
area:dev-tools
area:plugins
area:serialization
area:task-sdk
kind:documentation
provider:amazon
AWS/Amazon - related issues
provider:google
Google (including GCP) related issues
provider:standard
provider:yandex
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We moved the BaseOperatorLink to use a new machinery in #46609. BaseOperatorLink should reside now in the task sdk instead of models. This PR attempts to do that.
Testing
I have defined some plugins:
DAG used:
Loaded in UI:

Green run:

Button:

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.