Skip to content

Conversation

@jason810496
Copy link
Member

related: #42360


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Feb 28, 2025
@jason810496
Copy link
Member Author

Hi @rawwar, I think we may have overlooked the connection and variable endpoints. But it's not a big problem — I’ll take care of the variable one.

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the spec issue as other similar PRs.

#47192 (comment) for one hint.

@jason810496 jason810496 force-pushed the feature/AIP-84/auth/variable branch from e0b961c to f032a62 Compare March 3, 2025 13:11
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks, need rebase.

@jason810496 jason810496 force-pushed the feature/AIP-84/auth/variable branch from f032a62 to 1093e0d Compare March 3, 2025 14:26
@jedcunningham jedcunningham added the AIP-84 Modern Rest API label Mar 4, 2025
@jason810496 jason810496 force-pushed the feature/AIP-84/auth/variable branch from 1093e0d to c64e744 Compare March 4, 2025 12:00
@pierrejeambrun pierrejeambrun merged commit e012557 into apache:main Mar 4, 2025
43 checks passed
shahar1 pushed a commit to shahar1/airflow that referenced this pull request Mar 5, 2025
* AIP-84 | Add Auth for Variable

* Fix requires_access_variable schema
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
* AIP-84 | Add Auth for Variable

* Fix requires_access_variable schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AIP-84 Modern Rest API area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants