Decrease size of docker context by two orders of magnitude#47342
Merged
potiuk merged 1 commit intoapache:mainfrom Mar 4, 2025
Merged
Decrease size of docker context by two orders of magnitude#47342potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
When building docker image, local source files are sent as context. Unfortunately node and pnmp are adding a lot of cache inside the source tree and if we are not carefuly with excludin those, we end up with GBs of context being sent to docker before the build even starts (which takes minutes) This PR removes .pnpm-store folders that were the root cause for sending 1.5GB of context. It also adds simple instructions how you can check which files are in the context and how to see the size of the context. With this change, the context is down from 1.5 GB to 90 MB - cutting docker build context sending time from ~ minute to under a second.
potiuk
requested review from
bbovenzi,
eladkal,
pierrejeambrun and
vincbeck
and removed request for
ashb and
jedcunningham
pierrejeambrun
approved these changes
Mar 4, 2025
Contributor
|
Cool! |
shahar1
pushed a commit
to shahar1/airflow
that referenced
this pull request
Mar 5, 2025
) When building docker image, local source files are sent as context. Unfortunately node and pnmp are adding a lot of cache inside the source tree and if we are not carefuly with excludin those, we end up with GBs of context being sent to docker before the build even starts (which takes minutes) This PR removes .pnpm-store folders that were the root cause for sending 1.5GB of context. It also adds simple instructions how you can check which files are in the context and how to see the size of the context. With this change, the context is down from 1.5 GB to 90 MB - cutting docker build context sending time from ~ minute to under a second.
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
) When building docker image, local source files are sent as context. Unfortunately node and pnmp are adding a lot of cache inside the source tree and if we are not carefuly with excludin those, we end up with GBs of context being sent to docker before the build even starts (which takes minutes) This PR removes .pnpm-store folders that were the root cause for sending 1.5GB of context. It also adds simple instructions how you can check which files are in the context and how to see the size of the context. With this change, the context is down from 1.5 GB to 90 MB - cutting docker build context sending time from ~ minute to under a second.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building docker image, local source files are sent as context. Unfortunately node and pnmp are adding a lot of cache inside the source tree and if we are not carefuly with excludin those, we end up with GBs of context being sent to docker before the build even starts (which takes minutes)
This PR removes .pnpm-store folders that were the root cause for sending 1.5GB of context. It also adds simple instructions how you can check which files are in the context and how to see the size of the context. With this change, the context is down from 1.5 GB to 90 MB - cutting docker build context sending time from ~ minute to under a second.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.