Move task_sdk to a standalone task-sdk distribution #47451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
XD-DENG,
ashb,
jedcunningham and
mobuchowski
as code owners
boring-cyborg
bot
added
area:dev-tools
area:production-image
Member
Author
|
This is still not fully complete - some tests are failing but it proposes how we can move |
ashb
reviewed
Mar 6, 2025
providers/openlineage/tests/unit/openlineage/extractors/test_manager.py
Outdated
Show resolved
Hide resolved
ashb
reviewed
Mar 6, 2025
potiuk
force-pushed
the
move-task-sdk
branch
3 times, most recently
from
3f94c4c to
05ff95e
Compare
Member
Author
|
Looks good, green and straightforward :) |
ashb
reviewed
Mar 6, 2025
ashb
reviewed
Mar 6, 2025
potiuk
force-pushed
the
move-task-sdk
branch
2 times, most recently
from
4bd9c6e to
131a167
Compare
Member
Author
|
I moved the make_client stuff to |
This is the next stage of refactoring of airflow packages, after moving providers to standalone dstribution and separating devel-common as a common distribution. The `task_sdk` has been renamed to `task-sdk` - this way we will never import anything in task_sdk accidentally starting from content root. Some changes have been needed to make it works: * autouse fixture was added to pytest plugin to add `task-sdk/tests` to PYTHONPATH to make it root import * all tests were moved to `task_sdk` package inside the tests folder * all imports for tests are now `from task_sdk` * common tools for task_sdk has been moved to `devel-common/src/test_utils/task_sdk.py` in order to allow importing them before `task-sdk/tests` is added to pythonpath
amoghrajesh
reviewed
Mar 7, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Late here, but good work!
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
This is the next stage of refactoring of airflow packages, after moving providers to standalone dstribution and separating devel-common as a common distribution. The `task_sdk` has been renamed to `task-sdk` - this way we will never import anything in task_sdk accidentally starting from content root. Some changes have been needed to make it works: * autouse fixture was added to pytest plugin to add `task-sdk/tests` to PYTHONPATH to make it root import * all tests were moved to `task_sdk` package inside the tests folder * all imports for tests are now `from task_sdk` * common tools for task_sdk has been moved to `devel-common/src/test_utils/task_sdk.py` in order to allow importing them before `task-sdk/tests` is added to pythonpath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next stage of refactoring of airflow packages, after moving providers to standalone dstribution and separating devel-common as a common distribution.
The
task_sdkhas been renamed totask-sdk- this way we will never import anything in task_sdk accidentally starting from content root. Some changes have been needed to make it works:task-sdk/teststo PYTHONPATH to make it root importtask_sdkpackage inside the tests folderfrom task_sdkdevel-common/src/test_utils/task_sdk.pyin order to allow importing them beforetask-sdk/testsis added to pythonpath^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.