feat: Adjust DBT OpenLineage to Airflow 3 and improve logging #47500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacpermuda
commented
Mar 7, 2025
providers/dbt/cloud/src/airflow/providers/dbt/cloud/utils/openlineage.py
Show resolved
Hide resolved
mobuchowski
reviewed
Mar 7, 2025
providers/dbt/cloud/src/airflow/providers/dbt/cloud/operators/dbt.py
Outdated
Show resolved
Hide resolved
providers/dbt/cloud/src/airflow/providers/dbt/cloud/utils/openlineage.py
Show resolved
Hide resolved
kacpermuda
force-pushed
the
fix-ol-dbt-af3-run-id-adjustment
branch
from
7079b33 to
d7c29f7
Compare
mobuchowski
approved these changes
Mar 10, 2025
providers/dbt/cloud/src/airflow/providers/dbt/cloud/utils/openlineage.py
Show resolved
Hide resolved
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change in this PR is adjusting the way
_get_logical_datefunction works, now it should mimic OpenLineage listener's behavior. This is crucial, as OL run_id generated here must match the one generated by the listener, so that the parent-child relationship is correctly created.Additionally, some logs have been added that will be useful for debugging any issues with dbt OL extraction.
cc @mobuchowski
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.