Skip to content

Conversation

@eladkal
Copy link
Contributor

@eladkal eladkal commented Mar 10, 2025

Currently there is a miss match between what we should release and what is marked as ready.

Common messaging provider was merged as draft
fab 2.0 is not to be released till it's ready for Airflow 3.

@vincbeck @vikramkoka Whenever the providers are ready mark them as so and it will be released in the following wave. till then I'm marking them as not ready. Vikram note that we can release common messaging as 0.0.1 if you prefer (like we do with standard provider)

@vincbeck
Copy link
Contributor

Thanks! I agree with fab.

On common messaging, it is ready on my side but maybe @vikramkoka wants to update the documentation?

@potiuk
Copy link
Member

potiuk commented Mar 13, 2025

We need to add the not-ready providers to be build and prepared for PROD image - even if they are not ready (currently they are not). This is why docker-compose and k8s tests fail because they are installing fab provider 1.5.3 as the "not-ready" fab provider is excluded

@potiuk
Copy link
Member

potiuk commented Mar 13, 2025

Fixup is coming

@potiuk
Copy link
Member

potiuk commented Mar 13, 2025

The fixup I added should help

@eladkal
Copy link
Contributor Author

eladkal commented Mar 13, 2025

We need to add the not-ready providers to be build and prepared for PROD image - even if they are not ready (currently they are not). This is why docker-compose and k8s tests fail because they are installing fab provider 1.5.3 as the "not-ready" fab provider is excluded

Intresting. So why it wasn't needed for edge provider?

@potiuk
Copy link
Member

potiuk commented Mar 13, 2025

Intresting. So why it wasn't needed for edge provider?

Because edge provider (unlike FAB) is not (currently) needed for Airflow to run - it's not even installed in PROD image.

@potiuk
Copy link
Member

potiuk commented Mar 13, 2025

Rebased to latest version

@eladkal
Copy link
Contributor Author

eladkal commented Mar 14, 2025

Test failure is not related to the PR.
merging

@eladkal eladkal merged commit bef0927 into apache:main Mar 14, 2025
147 of 148 checks passed
@eladkal eladkal deleted the providers branch March 14, 2025 16:05
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Mar 21, 2025
* Marking fab and common messaging as not ready

* fix static checks

* fixup! fix static checks

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
* Marking fab and common messaging as not ready

* fix static checks

* fixup! fix static checks

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants