-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Rename get_permitted_dag_ids and filter_permitted_dag_ids to get_authorized_dag_ids and filter_authorized_dag_ids
#47640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1adc9b5 to
833945b
Compare
|
Please wait a little bit before merging that. Because it will cause conflicts on many different other PRs that we are about to merge, while this might be easier to just update this one ? |
Will do :) |
|
Which PRs exactly? Just so I can monitor them and know when to merge it |
833945b to
e2f86d1
Compare
|
Great thanks. I’m on my phone at the moment so it’s hard to link that but basically PRs for “AIP-84 Auth”. Multiple of them use those functions. (Dag tags, rawwar’s one too, and some others are coming). All of them should be linked to the meta “AIP-84 Permission” issue where it’s easier to monitor. |
|
I'll park it 👌 |
ff88ae2 to
4385dcb
Compare
…_authorized_dag_ids` and `filter_authorized_dag_ids`
4385dcb to
c5c190e
Compare
|
I think most of the related PRs have been merged. We can proceed here ! |
|
Let's go! |
…_authorized_dag_ids` and `filter_authorized_dag_ids` (apache#47640)
…_authorized_dag_ids` and `filter_authorized_dag_ids` (apache#47640)
To make it more consistent with the other methods (the verb
authorizeis used across all other APIs in auth manager), renameget_permitted_dag_idsandfilter_permitted_dag_idstoget_authorized_dag_idsandfilter_authorized_dag_ids^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.