Skip to content

Conversation

@vincbeck
Copy link
Contributor

To make it more consistent with the other methods (the verb authorize is used across all other APIs in auth manager), rename get_permitted_dag_ids and filter_permitted_dag_ids to get_authorized_dag_ids and filter_authorized_dag_ids


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@vincbeck vincbeck force-pushed the vincbeck/permitted branch 2 times, most recently from 1adc9b5 to 833945b Compare March 12, 2025 15:23
@vincbeck vincbeck requested a review from jedcunningham March 12, 2025 15:39
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Mar 12, 2025

Please wait a little bit before merging that.

Because it will cause conflicts on many different other PRs that we are about to merge, while this might be easier to just update this one ?

@vincbeck
Copy link
Contributor Author

Please wait a little bit before merging that.

Because it will cause conflicts on many different other PRs that we are about to merge, while this might be easier to just update this one ?

Will do :)

@vincbeck
Copy link
Contributor Author

Which PRs exactly? Just so I can monitor them and know when to merge it

@vincbeck vincbeck force-pushed the vincbeck/permitted branch from 833945b to e2f86d1 Compare March 12, 2025 17:56
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Mar 12, 2025

Great thanks. I’m on my phone at the moment so it’s hard to link that but basically PRs for “AIP-84 Auth”. Multiple of them use those functions. (Dag tags, rawwar’s one too, and some others are coming).

All of them should be linked to the meta “AIP-84 Permission” issue where it’s easier to monitor.

@vincbeck
Copy link
Contributor Author

I'll park it 👌

@vincbeck vincbeck force-pushed the vincbeck/permitted branch 2 times, most recently from ff88ae2 to 4385dcb Compare March 13, 2025 13:20
…_authorized_dag_ids` and `filter_authorized_dag_ids`
@vincbeck vincbeck force-pushed the vincbeck/permitted branch from 4385dcb to c5c190e Compare March 13, 2025 20:19
@pierrejeambrun
Copy link
Member

I think most of the related PRs have been merged. We can proceed here !

@vincbeck vincbeck merged commit af2461b into apache:main Mar 14, 2025
87 of 89 checks passed
@vincbeck vincbeck deleted the vincbeck/permitted branch March 14, 2025 15:07
@vincbeck
Copy link
Contributor Author

Let's go!

agupta01 pushed a commit to agupta01/airflow that referenced this pull request Mar 21, 2025
…_authorized_dag_ids` and `filter_authorized_dag_ids` (apache#47640)
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
…_authorized_dag_ids` and `filter_authorized_dag_ids` (apache#47640)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants