Handle BaseHook.get_connection's new Task SDK exception when connection is not found
#47648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
ramitkataria
changed the title
BaseHook.get_connection's new Task SDK exception in AwsGenericHookBaseHook.get_connection's new Task SDK exception
ramitkataria
changed the title
BaseHook.get_connection's new Task SDK exceptionBaseHook.get_connection's new Task SDK exception when connection is not found
Contributor
|
@ramitkataria is this a duplicate of #47593? |
ashb
approved these changes
Mar 12, 2025
Contributor
Author
I don't think so? It was still raising |
amoghrajesh
reviewed
Mar 13, 2025
Contributor
Yep, i noticed it. Thanks for your contribution @ramitkataria |
o-nikolas
approved these changes
Mar 14, 2025
Contributor
|
@amoghrajesh Is all your feedback addressed? Does this look ready to approve? |
amoghrajesh
approved these changes
Mar 18, 2025
Contributor
|
Needs rebase and resolve conflicts |
ramitkataria
force-pushed
the
ramitkataria/tasksdk-exception
branch
from
ac7890c to
a1bb15e
Compare
…en appropriate When a Task SDK connection is not found, it currently throws AirflowRuntimeError. This catches it in this case and raises AirflowNotFoundException for consistency.
ramitkataria
force-pushed
the
ramitkataria/tasksdk-exception
branch
from
a1bb15e to
ee7d4d2
Compare
prabhusneha
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 25, 2025
…tion is not found (apache#47648) When a Task SDK connection is not found, it currently throws AirflowRuntimeError. This PR catches it in this case and raises AirflowNotFoundException for consistency.
pankajkoti
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 28, 2025
…tion is not found (apache#47648) When a Task SDK connection is not found, it currently throws AirflowRuntimeError. This PR catches it in this case and raises AirflowNotFoundException for consistency.
shubham-pyc
pushed a commit
to shubham-pyc/airflow
that referenced
this pull request
Apr 2, 2025
…tion is not found (apache#47648) When a Task SDK connection is not found, it currently throws AirflowRuntimeError. This PR catches it in this case and raises AirflowNotFoundException for consistency.
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…tion is not found (apache#47648) When a Task SDK connection is not found, it currently throws AirflowRuntimeError. This PR catches it in this case and raises AirflowNotFoundException for consistency.
ramitkataria
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
May 8, 2025
In one of my previus PRs (apache#47648), I incorrectly assumed that catching the exception from `secrets_backend.get_connection` was meant for the connection not found case. So, I'm reversing a couple of changes from that PR for consistency.
ferruzzi
pushed a commit
that referenced
this pull request
May 12, 2025
* Fix consistency in exception/log handling in `connection.py` In one of my previus PRs (#47648), I incorrectly assumed that catching the exception from `secrets_backend.get_connection` was meant for the connection not found case. So, I'm reversing a couple of changes from that PR for consistency. * Change log message
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…50329) * Fix consistency in exception/log handling in `connection.py` In one of my previus PRs (apache#47648), I incorrectly assumed that catching the exception from `secrets_backend.get_connection` was meant for the connection not found case. So, I'm reversing a couple of changes from that PR for consistency. * Change log message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Task SDK connection is not found, it currently throws
AirflowRuntimeError. This PR catches it in this case and raisesAirflowNotFoundExceptionfor consistency.Earlier, I was changing
AwsGenericHookto also catch theAirflowRuntimeErrorbut I was getting import errors in tests. Then I realized it's probably better if this error handling is done where it was being done previously.After #47048, the boto fallback strategy started breaking inAwsGenericHook(explained in more detail here:#47048 (comment)). I realized that this was because a new exception
AirflowRuntimeErrorwas introduced inBaseHook'sget_connection. It used to only throwAirflowNotFoundExceptionearlier.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.