Including 'exc_notes' in our task-sdk tests coming from structlog #47663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
changed the title
potiuk
approved these changes
Mar 12, 2025
ashb
reviewed
Mar 12, 2025
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
Should we also increase the min version?
kaxil
approved these changes
Mar 12, 2025
Contributor
Author
|
The compat failure seems unrelated to my change, merging it |
ashb
added a commit
that referenced
this pull request
Mar 12, 2025
In #47663 we added the `exc_note` field, but that only appears with the latest structlog version. This was causing it to fail on some PRs
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structlog released a new version: https://pypi.org/project/structlog/ (25.2.0) which now introduced a feature to have
exc_notesto lookup notes attached to an exception: hynek/structlog#684This causes failures in our CI, example: https://github.com/apache/airflow/actions/runs/13805673163/job/38616566095?pr=47656
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.