Update conf deprecated_values for Airflow 3
#47761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does a few things: - cleans out old entries of `deprecated_values` - these have been emitting warnings in AF2 for a while now. - Remove the "update by version" from the warning. - Adds the old default value for `[logging] log_filename_template` into the list - this old default breaks logging in Airflow 3. Closes: apache#46972
eladkal
approved these changes
Mar 14, 2025
sunank200
approved these changes
Mar 14, 2025
Lee-W
added
the
airflow3.0:breaking
Lee-W
reviewed
Mar 14, 2025
|
|
||
| * Migration rules needed | ||
| * [ ] Remove ``[core] hostname`` configuration option from config if value is ``:`` | ||
| * [ ] Remove ``[email] email_backend`` configuration option from config if value is ``airflow.contrib.utils.sendgrid.send_email`` |
Member
There was a problem hiding this comment.
Instead of removing it, should we change it to airflow.providers.sendgrid.utils.emailer.send_email instead
Member
Author
There was a problem hiding this comment.
You could, all of these could, but duplicating default values isn't the best practice anyways.
Member
There was a problem hiding this comment.
yep, right. Thanks for confirming!
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 21, 2025
This PR does a few things: - cleans out old entries of `deprecated_values` - these have been emitting warnings in AF2 for a while now. - Remove the "update by version" from the warning. - Adds the old default value for `[logging] log_filename_template` into the list - this old default breaks logging in Airflow 3. Closes: apache#46972
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
This PR does a few things: - cleans out old entries of `deprecated_values` - these have been emitting warnings in AF2 for a while now. - Remove the "update by version" from the warning. - Adds the old default value for `[logging] log_filename_template` into the list - this old default breaks logging in Airflow 3. Closes: apache#46972
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
deprecated_values- these have been emitting warnings in AF2 for a while now.[logging] log_filename_templateinto the list - this old default breaks logging in Airflow 3.Closes: #46972