Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Mar 17, 2025

Why

We need asset_id in asset_expression as stated in #47753

What

Expand asset_expression to include asset_id when collecting assets and dags

close: #47753


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Lee-W Lee-W force-pushed the add-asset-id-to-asset-expression branch from 0c54f84 to dd87d2f Compare March 18, 2025 09:54
@Lee-W Lee-W force-pushed the add-asset-id-to-asset-expression branch from dd87d2f to 4a82013 Compare March 18, 2025 10:57
@Lee-W Lee-W marked this pull request as ready for review March 18, 2025 11:06
@Lee-W Lee-W changed the title feat(asset): add id to asset_expression feat(asset): add asset id to asset_expression Mar 18, 2025
@Lee-W
Copy link
Member Author

Lee-W commented Mar 18, 2025

cc @bbovenzi

Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gives me everything I need on the frontend

@Lee-W Lee-W merged commit 3378dbd into apache:main Mar 19, 2025
97 of 116 checks passed
@Lee-W Lee-W deleted the add-asset-id-to-asset-expression branch March 19, 2025 03:09
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Mar 21, 2025
* feat(asset): add id to asset_expression

* test: add test cases for updated asset_expression
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
* feat(asset): add id to asset_expression

* test: add test cases for updated asset_expression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add asset_id to DagModel.asset_expression

3 participants