-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix exponential backoff float overflow #48057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is a big enough change it probably needs some tests. However rather than maintaining this logic ourselves is it possible make use of https://github.com/hynek/stamina or https://tenacity.readthedocs.io/en/latest/ instead please? |
|
This PR targets v2-10-test branch. Is the issue affect only 2.10? The bug does not exist in main branch? |
|
Yeah. I rebased it. And this was my suggestion to just limit it - there was a much more complicated version of this PR #48051 - > I think for Airflow 2 that one should be "good enough". |
|
However we have to get the 2-10-test branch back in order which I believe we have @jason810496 working on it in #48404 and I am going to turn my attention to it as well finally to help. |
BTW. @ashb -> It would be interesitng to see if one of those handles it better, but that might be difficult to "test" it (and I would hate to add a dependency for it. We do not have stamina so far, but we do have tenacity, so if tenacity can be used to handle it - cool, but other than that, adding other dependency here feels like |
|
I looked at using tenacity bigger rewrite than is perhaps warranted. Also, I added the missing tests @ashb wanted in a PR against the branch. |
Revised to add unit tests ashb requested.
closes: #47971
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.