-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Checking modification timestamps only when newer_than is present
#48063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
newer_than is present
|
Done. Please consider merging. |
|
NIT: Is it also possible to have a test that shows that it IS called when newer_than is set?
With the next provider's release. We usually release every 2 weeks or so (see the docs about providers) but this is on a best-effort base and we are about to release Airlfow 3 so that might be skewed. This is open-source, no promises can be made with those as most people work here as volunteers. |
|
And you are not blocked. You are absolutely free to build your own provider version. Providers are absolutely standard packages now - with their own Also |
d20b281 to
d6094d2
Compare
Done Regarding release, thanks for letting me know :) |
|
Could you re-run pipeline please? |
…esent Checking modification timestamps has sagnificant impact on performance of sensors in ase of large amount of files.
|
Are there any actions needed from my side? |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
|
Just delays due to Airflow 3 :) |
…esent (apache#48063) Checking modification timestamps has sagnificant impact on performance of sensors in ase of large amount of files.
…esent (apache#48063) Checking modification timestamps has sagnificant impact on performance of sensors in ase of large amount of files.
…esent (apache#48063) Checking modification timestamps has sagnificant impact on performance of sensors in ase of large amount of files.

…esent
Checking modification timestamps has sagnificant impact on performance of sensors in ase of large amount of files.
This whole block of code do not need to be executed, when
newer_than=None^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.