[AIRFLOW_3982] Update DagRun state based on its tasks rather than DAG's #4808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Interesting. I never used the adhoc feature. |
Contributor
|
I've restarted the failing tests |
feng-tao
approved these changes
Mar 23, 2019
| dag.clear() | ||
| scheduler = SchedulerJob(dag_id, num_runs=2) | ||
| # we can't use dag.run or evaluate_dagrun because it uses BackfillJob | ||
| # instead of SchedulerJob and BackfillJobs are allowed to not respect start dates |
Member
There was a problem hiding this comment.
nit: you mean Unlike SchedulerJob, BackfillJobs are allowed to not respect start dates ?
Member
|
one small nit, LGTM |
Codecov Report
@@ Coverage Diff @@
## master #4808 +/- ##
==========================================
+ Coverage 75.3% 76.75% +1.45%
==========================================
Files 450 456 +6
Lines 29023 34723 +5700
==========================================
+ Hits 21855 26651 +4796
- Misses 7168 8072 +904
Continue to review full report at Codecov.
|
Member
======================================================================
57) FAIL: test_dagrun_root_after_dagrun_unfinished (tests.test_jobs.SchedulerJobTest)
----------------------------------------------------------------------
Traceback (most recent call last):
tests/test_jobs.py line 2556 in test_dagrun_root_after_dagrun_unfinished
self.assertEqual(first_run.state, State.SUCCESS)
AssertionError: u'running' != u'success'
- running
+ successI find out our master branch ci failed due to this PR merge yesterday, And I have to go to bed because is mid-night in my zone. Maybe someone could take a look? |
Member
|
will take a look |
ashb
pushed a commit
to ashb/airflow
that referenced
this pull request
Mar 25, 2019
cthenderson
pushed a commit
to cthenderson/apache-airflow
that referenced
this pull request
Apr 16, 2019
Contributor
|
@dima-asana I believe this change caused AIRFLOW-4428 bug |
andriisoldatenko
pushed a commit
to andriisoldatenko/airflow
that referenced
this pull request
Jul 26, 2019
wmorris75
pushed a commit
to modmed-external/incubator-airflow
that referenced
this pull request
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
If a DagRun does not have the same tasks as its DAG (e.g. a task is added or removed later), it should update its state based on its tasks rather than the DAG's.
This is probably mostly relevant when (a) adding a task to a DAG with a different start date and then (b) clearing a past DAG Run.
Note that this CR also removes the adhoc task references. The code path that led to this bug is attempting to exclude adhoc tasks, which don't exist anymore as of #1667. I've removed other references for consistency.
Tests
SchedulerJobTest.test_dagrun_root_after_dagrun_unfinished
Commits
Code Quality
flake8