-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Introducing worker configs for task sdk #48610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ashb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move where the execution api server URL is pulled form in the config in to this section too?
(If we do, lets make existing beta users' life easy and look at the current config location too)
@ashb ill check this in a follow up. |
closes: #48590
We have hardcoded certain configs for supervisor and for worker sdk API client. Allowing these options to be configurable will allow for more flexibility.
Introducing these changes under "workers" section in config.yml that was added earlier for #48446.
Testing
Default options:
Running this:
Overriding with these environment variables.
Ran the same script from above. Works as expected.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.