Improve logging of abnormal exit codes for supervised sub-processes. #49217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly for task processes. I have re-introduced the SIGSEGV message from apache#27381, the generic "exited with signal" message (previously nothing at all was logged for either of these two cases!), and additionally I have made the error for `exit(...)` less verbose -- a stack trace isn't useful there.
ashb
commented
Apr 14, 2025
ashb
commented
Apr 14, 2025
kaxil
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly for task processes.
I have re-introduced the SIGSEGV message from #27381, the generic "exited with
signal" message (previously nothing at all was logged for either of these two
cases!), and additionally I have made the error for
exit(...)less verbose-- a stack trace isn't useful there.
exit()behaviourBefore
After
SIGKILL
Before
After
SIGSEGV
Before
After
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.