-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Delete duplicate mock_supervisor_comms pytest fixtures from OL provider
#49520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mobuchowski
merged 13 commits into
apache:main
from
astronomer:delete_mock_function_defn_from_providers
Apr 22, 2025
Merged
Delete duplicate mock_supervisor_comms pytest fixtures from OL provider
#49520
mobuchowski
merged 13 commits into
apache:main
from
astronomer:delete_mock_function_defn_from_providers
Apr 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mock_supervisor_comms pytest fixtures from OL provider
amoghrajesh
approved these changes
Apr 22, 2025
Contributor
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
mobuchowski
approved these changes
Apr 22, 2025
prabhusneha
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
…ider (apache#49520) * Remove duplicate mock_supervisor_comms pytest fixture definitions * Remove duplicate mock_supervisor_comms pytest fixture definitions * Revert * Remove mock_supervisor_comms definition from conftest * Remove duplicate mock_supervisor_comms definition from provider * Fix static check --------- Co-authored-by: Sneha Prabhu <snehaprabhu@Snehas-MacBook-Pro.local> Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mock_supervisor_comms pytest fixture is already defined in devel-common/src/tests_common/pytest_plugin.py
We do not need to have another definition in providers/openlineage/tests/unit/openlineage/plugins/test_listener.py.
Related: #49457