Skip to content

Conversation

@prabhusneha
Copy link
Contributor

@prabhusneha prabhusneha commented Apr 21, 2025

mock_supervisor_comms pytest fixture is already defined in devel-common/src/tests_common/pytest_plugin.py
We do not need to have another definition in providers/openlineage/tests/unit/openlineage/plugins/test_listener.py.

Related: #49457

@amoghrajesh amoghrajesh self-requested a review April 22, 2025 06:05
@amoghrajesh amoghrajesh changed the title Delete duplicate mock_supervisor_comms pytest fixture definition from providers Delete duplicate mock_supervisor_comms pytest fixtures from OL provider Apr 22, 2025
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@mobuchowski mobuchowski merged commit efc239c into apache:main Apr 22, 2025
66 checks passed
prabhusneha pushed a commit to astronomer/airflow that referenced this pull request Apr 25, 2025
…ider (apache#49520)

* Remove duplicate mock_supervisor_comms pytest fixture definitions

* Remove duplicate mock_supervisor_comms pytest fixture definitions

* Revert

* Remove mock_supervisor_comms definition from conftest

* Remove duplicate mock_supervisor_comms definition from provider

* Fix static check

---------

Co-authored-by: Sneha Prabhu <snehaprabhu@Snehas-MacBook-Pro.local>
Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants