Fix infinite redirect in FAB AuthManager caused by mistakenly setting token cookie as secure #49724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… token cookie as secure `api/ssl_cert` has a default value of "" so `has_option` is always returning true, so we have to find in a slightly more complex way of telling if this setting is turned on. Provider version of apache#49721
2 tasks
vincbeck
approved these changes
Apr 24, 2025
pierrejeambrun
approved these changes
Apr 24, 2025
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Thanks.
That has been updated multiple times and I guess we lost track a little bit there.
prabhusneha
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
… token cookie as secure (apache#49724) `api/ssl_cert` has a default value of "" so `has_option` is always returning true, so we have to find in a slightly more complex way of telling if this setting is turned on. Provider version of apache#49721
8 tasks
jroachgolf84
pushed a commit
to jroachgolf84/airflow
that referenced
this pull request
Apr 30, 2025
… token cookie as secure (apache#49724) `api/ssl_cert` has a default value of "" so `has_option` is always returning true, so we have to find in a slightly more complex way of telling if this setting is turned on. Provider version of apache#49721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api/ssl_certhas a default value of "" sohas_optionis always returningtrue, so we have to find in a slightly more complex way of telling if this
setting is turned on.
Provider version of #49721.
Relates to #49495
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.