Refactor connection creation in system tests to use REST API instead#49804
Refactor connection creation in system tests to use REST API instead#49804o-nikolas merged 3 commits intoapache:mainfrom
Conversation
|
We might eventually replace it with with python client - but I think it's good enough for now cc: @VladaZakharova @kosteev ? |
|
BTW. The errors are unrelated - one of them random, one of them being fixed in main. |
providers/amazon/tests/system/amazon/aws/example_google_api_youtube_to_s3.py
Outdated
Show resolved
Hide resolved
57bef8a to
0600974
Compare
51ec100 to
2893ec6
Compare
|
Hi @potiuk
Is error occurring right now the one being fixed in main? Otherwise I was thinking of moving the import statement to be inside the function |
|
@ramitkataria -> Generelly when in doubt - rebase and check if it still fails. |
2893ec6 to
bff0268
Compare
Since direct DB access is not permitted in Airflow 3 due to Task SDK, the these system tests were failing during connection creation when run with Task SDK. This refactors the tests so they use REST API to create the connection. Also added a helper method to make REST API calls for tests without having to manually create the request. I've tested the `create_connection` task and confirmed it does create the connection.
bff0268 to
2d25b6e
Compare
Since direct DB access is not permitted in Airflow 3 due to Task SDK, the these system tests were failing during connection creation when run with Task SDK. This refactors the tests so they use REST API to create the connection.
Also added a helper method to make REST API calls for tests without having to manually create the request.
I've tested the
create_connectiontask and confirmed it does create the connection.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.