Skip to content

Conversation

@milton0825
Copy link
Contributor

@milton0825 milton0825 commented Mar 29, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

1-setup-env.sh should only be ran inside the docker container as it override files.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Modified the CI bash script should not need unit test I guess?

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@milton0825 milton0825 changed the title Env sh only run in docker [AIRFLOW-XXX] 1-setup-env.sh should only run in docker Mar 29, 2019
@milton0825 milton0825 force-pushed the env-sh-only-run-in-docker branch from 742e67b to a2170c1 Compare March 29, 2019 14:55
[AIRFLOW-XXX] 1-setup-env.sh should only run in docker
@milton0825 milton0825 force-pushed the env-sh-only-run-in-docker branch from a2170c1 to fa5d02f Compare March 29, 2019 14:58
@milton0825
Copy link
Contributor Author

@ashb

@potiuk
Copy link
Member

potiuk commented Mar 29, 2019

It's really good idea. I've added very similar solution to my WIP PR for multi-staging. The nice thing there is that the image to run CI is part of airflow itself and we already had a few ENV variables defined that we could use.

#4938 (but I added it in all scripts that are run in the container - there are a few places to add it: 9a94899#diff-9cf9f4241b4e721774c938abb1c6c103R25

@feng-tao
Copy link
Member

lgtm

@milton0825
Copy link
Contributor Author

@feng-tao feng-tao merged commit 9d8719e into apache:master Mar 29, 2019
@milton0825 milton0825 deleted the env-sh-only-run-in-docker branch April 13, 2019 19:04
cthenderson pushed a commit to cthenderson/apache-airflow that referenced this pull request Apr 16, 2019
[AIRFLOW-XXX] 1-setup-env.sh should only run in docker
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
[AIRFLOW-XXX] 1-setup-env.sh should only run in docker
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
[AIRFLOW-XXX] 1-setup-env.sh should only run in docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants