-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Set proper task-sdk limits for main #50163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0289e00 to
a114dcd
Compare
Member
Author
|
Found it our when testing 3.0.1 release |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 4, 2025
The task SDK we have currently is not yet fully decoupled from the Airflow version we are going to have. It is simply not "future compatible" yet. The "true" decoupling will come when we have Airflow 3.1, for now the task-sdk we have is really tied with 3.1.* version of Airflow - and for now we should have the limits set properly for core: * Lower >= 3.0.0 -> the main version of task-sdk will only work with airflow 3.0.* (including pre-releases) * Upper < 3.1.0 -> the task-sdk from main (1.1.0) will not work with Airflow 3.0.* and it's not going to be installable for Airflow 3.0 as well. Related to apache#50163
a114dcd to
154b916
Compare
The task SDK we have currently is not yet fully decoupled from the Airflow version we are going to have. It is simply not "future compatible" yet. The "true" decoupling will come when we have Airflow 3.1, for now the task-sdk we have is really tied with 3.1.* version of Airflow - and for now we should have the limits set properly for core: * Lower >= 3.1.0 -> the main version of task-sdk will only work with airflow 3.1.0 (including pre-releases) * Upper < 3.2.0 -> for now we set it to < 3.2.0 to allow any version of Task SDK 1.1.0 to be installed on any version of Airflow 3.1.* in the future. We might relax this limit before we release 3.1.0 if we consider that task-sdk is ready to be future-compatible as well. Similarly task-sdk 1.0.* is not going to be installable for 3.1.0, so we need to set the lower-binding of task-sdk for airflow-core to 1.1.0
154b916 to
2f5c565
Compare
jscheffl
approved these changes
May 4, 2025
potiuk
added a commit
that referenced
this pull request
May 4, 2025
The task SDK we have currently is not yet fully decoupled from the Airflow version we are going to have. It is simply not "future compatible" yet. The "true" decoupling will come when we have Airflow 3.1, for now the task-sdk we have is really tied with 3.1.* version of Airflow - and for now we should have the limits set properly for core: * Lower >= 3.0.0 -> the main version of task-sdk will only work with airflow 3.0.* (including pre-releases) * Upper < 3.1.0 -> the task-sdk from main (1.1.0) will not work with Airflow 3.0.* and it's not going to be installable for Airflow 3.0 as well. Related to #50163
mvfc
pushed a commit
to mvfc/airflow
that referenced
this pull request
May 6, 2025
The task SDK we have currently is not yet fully decoupled from the Airflow version we are going to have. It is simply not "future compatible" yet. The "true" decoupling will come when we have Airflow 3.1, for now the task-sdk we have is really tied with 3.1.* version of Airflow - and for now we should have the limits set properly for core: * Lower >= 3.1.0 -> the main version of task-sdk will only work with airflow 3.1.0 (including pre-releases) * Upper < 3.2.0 -> for now we set it to < 3.2.0 to allow any version of Task SDK 1.1.0 to be installed on any version of Airflow 3.1.* in the future. We might relax this limit before we release 3.1.0 if we consider that task-sdk is ready to be future-compatible as well. Similarly task-sdk 1.0.* is not going to be installable for 3.1.0, so we need to set the lower-binding of task-sdk for airflow-core to 1.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task SDK we have currently is not yet fully decoupled from the Airflow version we are going to have. It is simply not "future compatible" yet.
The "true" decoupling will come when we have Airflow 3.1, for now the task-sdk we have is really tied with 3.1.* version of Airflow - and for now we should have the limits set properly for core:
Similarly task-sdk 1.0.* is not going to be installable for 3.1.0, so we need to set the lower-binding of task-sdk for airflow-core to 1.1.0
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.