Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented May 4, 2025

The task SDK we have currently is not yet fully decoupled from the Airflow version we are going to have. It is simply not "future compatible" yet.

The "true" decoupling will come when we have Airflow 3.1, for now the task-sdk we have is really tied with 3.1.* version of Airflow - and for now we should have the limits set properly for core:

  • Lower >= 3.1.0 -> the main version of task-sdk will only work with airflow 3.1.0 (including pre-releases)
  • Upper < 3.2.0 -> for now we set it to < 3.2.0 to allow any version of Task SDK 1.1.0 to be installed on any version of Airflow 3.1.* in the future. We might relax this limit before we release 3.1.0 if we consider that task-sdk is ready to be future-compatible as well.

Similarly task-sdk 1.0.* is not going to be installable for 3.1.0, so we need to set the lower-binding of task-sdk for airflow-core to 1.1.0


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk potiuk requested review from amoghrajesh, ashb and kaxil as code owners May 4, 2025 07:53
@potiuk potiuk requested a review from eladkal May 4, 2025 07:53
@potiuk potiuk force-pushed the proper-task-sdk-limit branch from 0289e00 to a114dcd Compare May 4, 2025 07:54
@potiuk
Copy link
Member Author

potiuk commented May 4, 2025

Found it our when testing 3.0.1 release

potiuk added a commit to potiuk/airflow that referenced this pull request May 4, 2025
The task SDK we have currently is not yet fully decoupled from the
Airflow version we are going to have. It is simply not "future
compatible" yet.

The "true" decoupling will come when we have Airflow 3.1, for now the
task-sdk we have is really tied with 3.1.* version of Airflow - and for
now we should have the limits set properly for core:

* Lower >= 3.0.0 -> the main version of task-sdk will only work with
  airflow 3.0.* (including pre-releases)
* Upper < 3.1.0 -> the task-sdk from main (1.1.0) will not work with
  Airflow 3.0.* and it's not going to be installable for Airflow 3.0
  as well.

Related to apache#50163
@potiuk potiuk force-pushed the proper-task-sdk-limit branch from a114dcd to 154b916 Compare May 4, 2025 08:02
@potiuk potiuk changed the title Set proper task-sdk limits for Task SDK Set proper task-sdk limits for main May 4, 2025
The task SDK we have currently is not yet fully decoupled from the
Airflow version we are going to have. It is simply not "future
compatible" yet.

The "true" decoupling will come when we have Airflow 3.1, for now the
task-sdk we have is really tied with 3.1.* version of Airflow - and for
now we should have the limits set properly for core:

* Lower >= 3.1.0 -> the main version of task-sdk will only work with airflow
  3.1.0 (including pre-releases)
* Upper < 3.2.0 -> for now we set it to < 3.2.0 to allow any version of
  Task SDK 1.1.0 to be installed on any version of Airflow 3.1.* in
  the future. We might relax this limit before we release 3.1.0 if
  we consider that task-sdk is ready to be future-compatible as well.

Similarly task-sdk 1.0.* is not going to be installable for 3.1.0, so
we need to set the lower-binding of task-sdk for airflow-core to 1.1.0
@potiuk potiuk force-pushed the proper-task-sdk-limit branch from 154b916 to 2f5c565 Compare May 4, 2025 08:03
@potiuk potiuk requested review from gopidesupavan and jscheffl May 4, 2025 08:03
@potiuk potiuk merged commit 2ce7e2a into apache:main May 4, 2025
50 checks passed
@potiuk potiuk deleted the proper-task-sdk-limit branch May 4, 2025 08:47
potiuk added a commit that referenced this pull request May 4, 2025
The task SDK we have currently is not yet fully decoupled from the
Airflow version we are going to have. It is simply not "future
compatible" yet.

The "true" decoupling will come when we have Airflow 3.1, for now the
task-sdk we have is really tied with 3.1.* version of Airflow - and for
now we should have the limits set properly for core:

* Lower >= 3.0.0 -> the main version of task-sdk will only work with
  airflow 3.0.* (including pre-releases)
* Upper < 3.1.0 -> the task-sdk from main (1.1.0) will not work with
  Airflow 3.0.* and it's not going to be installable for Airflow 3.0
  as well.

Related to #50163
mvfc pushed a commit to mvfc/airflow that referenced this pull request May 6, 2025
The task SDK we have currently is not yet fully decoupled from the
Airflow version we are going to have. It is simply not "future
compatible" yet.

The "true" decoupling will come when we have Airflow 3.1, for now the
task-sdk we have is really tied with 3.1.* version of Airflow - and for
now we should have the limits set properly for core:

* Lower >= 3.1.0 -> the main version of task-sdk will only work with airflow
  3.1.0 (including pre-releases)
* Upper < 3.2.0 -> for now we set it to < 3.2.0 to allow any version of
  Task SDK 1.1.0 to be installed on any version of Airflow 3.1.* in
  the future. We might relax this limit before we release 3.1.0 if
  we consider that task-sdk is ready to be future-compatible as well.

Similarly task-sdk 1.0.* is not going to be installable for 3.1.0, so
we need to set the lower-binding of task-sdk for airflow-core to 1.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants