[v3-0-test] Adding backcompat shim for BaseNotifier (#50340) #50384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding backcompat shim for BaseNotifier * Adding deprecation warning too * using deprecation properly (cherry picked from commit bf99522) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
kaxil
approved these changes
May 9, 2025
potiuk
approved these changes
May 9, 2025
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding backcompat shim for BaseNotifier
Adding deprecation warning too
using deprecation properly
(cherry picked from commit bf99522)
Co-authored-by: Amogh Desai amoghrajesh1999@gmail.com