-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Limit click to < 8.2.0 for breeze #50452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Just to add pallets/click#2896 -> this is likely a mistake when releasing 8.2.0 by click maintainers. |
Breeze can be installed with a different python version than minimum and it can self-upgrade to 8.2.0 of click which is Python 3.10+ (released today). That version of click is not compatible with breezes custom choices and we need to limit it for now until we can set 8.2.0 of click as minimum (when we move to Python 3.10+)
79d5767 to
251c939
Compare
eladkal
approved these changes
May 11, 2025
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 11, 2025
Breeze can be installed with a different python version than minimum and it can self-upgrade to 8.2.0 of click which is Python 3.10+ (released today). That version of click is not compatible with breezes custom choices and we need to limit it for now until we can set 8.2.0 of click as minimum (when we move to Python 3.10+) (cherry picked from commit 6019e15) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
May 11, 2025
Breeze can be installed with a different python version than minimum and it can self-upgrade to 8.2.0 of click which is Python 3.10+ (released today). That version of click is not compatible with breezes custom choices and we need to limit it for now until we can set 8.2.0 of click as minimum (when we move to Python 3.10+) (cherry picked from commit 6019e15)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 11, 2025
Breeze can be installed with a different python version than minimum and it can self-upgrade to 8.2.0 of click which is Python 3.10+ (released today). That version of click is not compatible with breezes custom choices and we need to limit it for now until we can set 8.2.0 of click as minimum (when we move to Python 3.10+) (cherry picked from commit 6019e15) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
May 11, 2025
Breeze can be installed with a different python version than minimum and it can self-upgrade to 8.2.0 of click which is Python 3.10+ (released today). That version of click is not compatible with breezes custom choices and we need to limit it for now until we can set 8.2.0 of click as minimum (when we move to Python 3.10+) (cherry picked from commit 6019e15)
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
Breeze can be installed with a different python version than minimum and it can self-upgrade to 8.2.0 of click which is Python 3.10+ (released today). That version of click is not compatible with breezes custom choices and we need to limit it for now until we can set 8.2.0 of click as minimum (when we move to Python 3.10+) (cherry picked from commit 6019e15)
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
Breeze can be installed with a different python version than minimum and it can self-upgrade to 8.2.0 of click which is Python 3.10+ (released today). That version of click is not compatible with breezes custom choices and we need to limit it for now until we can set 8.2.0 of click as minimum (when we move to Python 3.10+)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breeze can be installed with a different python version than minimum and it can self-upgrade to 8.2.0 of click which is Python 3.10+ (released today). That version of click is not compatible with breezes custom choices and we need to limit it for now until we can set 8.2.0 of click as minimum (when we move to Python 3.10+)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.