Skip to content

Conversation

@amoghrajesh
Copy link
Contributor

Similar to #50716

Updating the K8s schema fetch logic to use the Github API instead of using the raw.githubuser.com, which had limited support for GH tokens. Hence it was running into rate limiting errors like:

........................................................................ [ 25%]
............F........................................................... [ 51%]
........................................................................ [ 76%]
..................................................................       [100%]
=================================== FAILURES ===================================
_ TestGitSyncWorker.test_should_add_dags_volume_to_the_worker_if_git_sync_and_persistence_is_enabled _
[gw3] linux -- Python 3.9.22 /usr/local/bin/python3

self = <helm_tests.other.test_git_sync_worker.TestGitSyncWorker object at 0xffdf80633b20>

    def test_should_add_dags_volume_to_the_worker_if_git_sync_and_persistence_is_enabled(self):
>       docs = render_chart(
            values={
                "executor": "CeleryExecutor",
                "dags": {"persistence": {"enabled": True}, "gitSync": {"enabled": True}},
            },
            show_only=["templates/workers/worker-deployment.yaml"],
        )

helm-tests/tests/helm_tests/other/test_git_sync_worker.py:27: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helm-tests/tests/chart_utils/helm_template_generator.py:165: in render_chart
    validate_k8s_object(k8s_object, kubernetes_version)
helm-tests/tests/chart_utils/helm_template_generator.py:116: in validate_k8s_object
    validate = create_validator(instance.get("apiVersion"), instance.get("kind"), kubernetes_version)
helm-tests/tests/chart_utils/helm_template_generator.py:99: in create_validator
    schema = get_schema_k8s(api_version, kind, kubernetes_version)
helm-tests/tests/chart_utils/helm_template_generator.py:71: in get_schema_k8s
    request.raise_for_status()

Example: https://github.com/apache/airflow/actions/runs/15086622656/job/42410644771


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk potiuk added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label May 17, 2025
@potiuk potiuk added this to the Airflow 3.0.2 milestone May 17, 2025
@potiuk potiuk merged commit 41ddc9f into apache:main May 17, 2025
60 checks passed
github-actions bot pushed a commit that referenced this pull request May 17, 2025
…50729)

(cherry picked from commit 41ddc9f)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
@github-actions
Copy link

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

potiuk pushed a commit that referenced this pull request May 17, 2025
…50729) (#50731)

(cherry picked from commit 41ddc9f)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
kaxil pushed a commit that referenced this pull request May 19, 2025
…50729) (#50731)

(cherry picked from commit 41ddc9f)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
@kaxil kaxil removed this from the Airflow 3.0.2 milestone Jun 3, 2025
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50729) (#50731)

(cherry picked from commit 41ddc9f)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants