Fix ConfigResponse types to handle nulls #50918
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was crashing api server.
dstandish
requested review from
bbovenzi,
bugraoz93,
ephraimbuddy,
jason810496,
jscheffl,
pierrejeambrun,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
boring-cyborg
bot
added
area:API
sunank200
reviewed
May 21, 2025
| auto_refresh_interval: int | None | ||
| hide_paused_dags_by_default: bool | None | ||
| instance_name: str | ||
| enable_swagger_ui: bool |
Collaborator
There was a problem hiding this comment.
What about other attributes? Can they not be None?
Contributor
Author
There was a problem hiding this comment.
don't know; but, webserver does not crash now.
ashb
reviewed
May 21, 2025
| page_size: int | ||
| auto_refresh_interval: int | ||
| hide_paused_dags_by_default: bool | ||
| page_size: int | None |
Member
There was a problem hiding this comment.
Aren't these all meant to have defaults in the configs, so they shouldn't actually be null, right @pierrejeambrun
Member
There was a problem hiding this comment.
Yes, this looks odd, I’ll take a look tomorrow.
Member
|
Is this needed with #50902 |
Contributor
Author
tis not. closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was crashing api server.