-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Always show backfill button but enable it only on dags with schedule. #50969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks
|
Mhm, I just see this change and... actually I dis-like it. I undrstand that people seeking for (the new cool feature to backfill as advertised) and can not see it if no schedule. BUT: The new UI uses a lot more whitespace and when using the trigger form as modal a lot of screen space is occupied for a selection that is actually not a benefit if you just want to trigger. Could we make this somehow configurable? In my view it just clutters the UI when no backfill possible. |
|
Later on the UI will also handle the permissions, which means that this button will most likely disappear again if users do not have permissions to create backfill. Maybe that could be a workaround => Don't give user backfill permissions if you don't want them to see the disabled button. (But that's 3.1.0+ unfortunately). |
Closes #50904