Rds Operator pass custom conn_id to superclass #51196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
dominikhei
changed the title
o-nikolas
reviewed
May 29, 2025
providers/amazon/src/airflow/providers/amazon/aws/operators/rds.py
Outdated
Show resolved
Hide resolved
o-nikolas
approved these changes
May 29, 2025
Contributor
Author
|
@o-nikolas I was just skimming through the other AWS operators to look for similar bugs and found that the operators for cloud formation, comprehend and glue still set the |
Contributor
Yupp, that's a reasonable plan, would you like to put up a separate PR for that? |
Contributor
Author
Already opened it #51236 :) |
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* Adjuste RDSHook to pass aws_conn_id to Hooks * Added tests for changes and changed name of defaul conn_id in in RdsBaseOperator * Fixed pre-commit errors * Removed unnecessary args from RDSBaseOperator
This was referenced Jun 15, 2025
seanghaeli
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 24, 2025
… adjust the default value of in base class to . - Add defensive test around adding more task instance states to keep of the MwaaTaskCompletedTrigger up to date. - Fix issue where of the MwaaTaskSensor derives to instead of type. - Modify documentation to clearly indicate that the MwaaTaskSensor is meant to sense tasks across different MWAA environments. - Make an optional parameter, where it defaults to the latest dag run. - Externally fetch the task ID variable. - Test the sensor while a DAG Run is still in progress.
jose-lehmkuhl
pushed a commit
to jose-lehmkuhl/airflow
that referenced
this pull request
Jul 11, 2025
* Adjuste RDSHook to pass aws_conn_id to Hooks * Added tests for changes and changed name of defaul conn_id in in RdsBaseOperator * Fixed pre-commit errors * Removed unnecessary args from RDSBaseOperator
seanghaeli
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jul 23, 2025
… adjust the default value of in base class to . - Add defensive test around adding more task instance states to keep of the MwaaTaskCompletedTrigger up to date. - Fix issue where of the MwaaTaskSensor derives to instead of type. - Modify documentation to clearly indicate that the MwaaTaskSensor is meant to sense tasks across different MWAA environments. - Make an optional parameter, where it defaults to the latest dag run. - Externally fetch the task ID variable. - Test the sensor while a DAG Run is still in progress.
vincbeck
pushed a commit
that referenced
this pull request
Aug 5, 2025
* Add MwaaTaskSensor to Amazon Provider Package * include pre-commit hooks * - Comply with PR #51196: explicitly pass to its superclass, and adjust the default value of in base class to . - Add defensive test around adding more task instance states to keep of the MwaaTaskCompletedTrigger up to date. - Fix issue where of the MwaaTaskSensor derives to instead of type. - Modify documentation to clearly indicate that the MwaaTaskSensor is meant to sense tasks across different MWAA environments. - Make an optional parameter, where it defaults to the latest dag run. - Externally fetch the task ID variable. - Test the sensor while a DAG Run is still in progress. * documentation update * Response to PR #51719 comments - Brought UPSTREAM_FAILED to a Terminal Task Instance State instead of an Intermediate State. - Added REMOVED to the list of successful terminal task instance states. - Iterate programmatically through successful, failure, and in progress states instead of hard-coding. * update tests * Remove duplicate pointer to mwaatasksensor docs * merge #53000 * Fix integration tests * removed unnecessary defensive tests for trigger acceptor states after #53000 merge * removed unnecessary defensive tests for trigger acceptor states after #53000 merge * remove State file from PR * Remove hard coding deferrable property * Remove unnecessary execute_complete function in sensor and instead use end_from_trigger * Correctly use end_from_trigger attribute * Correctly use end_from_trigger attibute for both dag run sensor and task sensor * Remove unnecessary import
HsiuChuanHsu
pushed a commit
to HsiuChuanHsu/airflow
that referenced
this pull request
Aug 5, 2025
* Add MwaaTaskSensor to Amazon Provider Package * include pre-commit hooks * - Comply with PR apache#51196: explicitly pass to its superclass, and adjust the default value of in base class to . - Add defensive test around adding more task instance states to keep of the MwaaTaskCompletedTrigger up to date. - Fix issue where of the MwaaTaskSensor derives to instead of type. - Modify documentation to clearly indicate that the MwaaTaskSensor is meant to sense tasks across different MWAA environments. - Make an optional parameter, where it defaults to the latest dag run. - Externally fetch the task ID variable. - Test the sensor while a DAG Run is still in progress. * documentation update * Response to PR apache#51719 comments - Brought UPSTREAM_FAILED to a Terminal Task Instance State instead of an Intermediate State. - Added REMOVED to the list of successful terminal task instance states. - Iterate programmatically through successful, failure, and in progress states instead of hard-coding. * update tests * Remove duplicate pointer to mwaatasksensor docs * merge apache#53000 * Fix integration tests * removed unnecessary defensive tests for trigger acceptor states after apache#53000 merge * removed unnecessary defensive tests for trigger acceptor states after apache#53000 merge * remove State file from PR * Remove hard coding deferrable property * Remove unnecessary execute_complete function in sensor and instead use end_from_trigger * Correctly use end_from_trigger attribute * Correctly use end_from_trigger attibute for both dag run sensor and task sensor * Remove unnecessary import
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 7, 2025
* Add MwaaTaskSensor to Amazon Provider Package * include pre-commit hooks * - Comply with PR apache#51196: explicitly pass to its superclass, and adjust the default value of in base class to . - Add defensive test around adding more task instance states to keep of the MwaaTaskCompletedTrigger up to date. - Fix issue where of the MwaaTaskSensor derives to instead of type. - Modify documentation to clearly indicate that the MwaaTaskSensor is meant to sense tasks across different MWAA environments. - Make an optional parameter, where it defaults to the latest dag run. - Externally fetch the task ID variable. - Test the sensor while a DAG Run is still in progress. * documentation update * Response to PR apache#51719 comments - Brought UPSTREAM_FAILED to a Terminal Task Instance State instead of an Intermediate State. - Added REMOVED to the list of successful terminal task instance states. - Iterate programmatically through successful, failure, and in progress states instead of hard-coding. * update tests * Remove duplicate pointer to mwaatasksensor docs * merge apache#53000 * Fix integration tests * removed unnecessary defensive tests for trigger acceptor states after apache#53000 merge * removed unnecessary defensive tests for trigger acceptor states after apache#53000 merge * remove State file from PR * Remove hard coding deferrable property * Remove unnecessary execute_complete function in sensor and instead use end_from_trigger * Correctly use end_from_trigger attribute * Correctly use end_from_trigger attibute for both dag run sensor and task sensor * Remove unnecessary import
fweilun
pushed a commit
to fweilun/airflow
that referenced
this pull request
Aug 11, 2025
* Add MwaaTaskSensor to Amazon Provider Package * include pre-commit hooks * - Comply with PR apache#51196: explicitly pass to its superclass, and adjust the default value of in base class to . - Add defensive test around adding more task instance states to keep of the MwaaTaskCompletedTrigger up to date. - Fix issue where of the MwaaTaskSensor derives to instead of type. - Modify documentation to clearly indicate that the MwaaTaskSensor is meant to sense tasks across different MWAA environments. - Make an optional parameter, where it defaults to the latest dag run. - Externally fetch the task ID variable. - Test the sensor while a DAG Run is still in progress. * documentation update * Response to PR apache#51719 comments - Brought UPSTREAM_FAILED to a Terminal Task Instance State instead of an Intermediate State. - Added REMOVED to the list of successful terminal task instance states. - Iterate programmatically through successful, failure, and in progress states instead of hard-coding. * update tests * Remove duplicate pointer to mwaatasksensor docs * merge apache#53000 * Fix integration tests * removed unnecessary defensive tests for trigger acceptor states after apache#53000 merge * removed unnecessary defensive tests for trigger acceptor states after apache#53000 merge * remove State file from PR * Remove hard coding deferrable property * Remove unnecessary execute_complete function in sensor and instead use end_from_trigger * Correctly use end_from_trigger attribute * Correctly use end_from_trigger attibute for both dag run sensor and task sensor * Remove unnecessary import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50766
I have adjusted the
RdsBaseOperatorclass to explicitly pass theaws_conn_idto its superclass, such that if a custom conn_id is provided the super class does not fall back to the default and the base classes receive the correct conn_id.Moreover I have adjusted the name of the default value of the aws_conn_id in RdsBaseOperator from
aws_conn_idtoaws_default, to be consistent with the RdsBaseOperator and all other operators.