[v3-0-test] Fix deferred task resumption in dag.test() (#51182)
#51199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `dag.test()` with deferred tasks, tasks that complete their trigger execution were incorrectly being set to `SUCCESS` state instead of `SCHEDULED` state. This prevented task resumption!
Dag used to test:
```python
from datetime import datetime, timedelta, timezone
from typing import Any
import pendulum
from airflow.providers.standard.triggers.temporal import DateTimeTrigger
from airflow.sdk import Context, task, BaseOperator, DAG
class DummyOperator(BaseOperator):
def execute(self, context: Context):
self.defer(
trigger=DateTimeTrigger(
moment=datetime.now(timezone.utc) + timedelta(seconds=2),
),
method_name="execute_complet",
)
def execute_complet(self, context: Context, event: Any = None):
assert event is not None
return "test"
@task
def dummy_task(param):
print("DEBUG")
assert param == "test", "Parameter should be 'test'"
with DAG(
dag_id="example_debug",
start_date=pendulum.datetime(2021, 1, 1, tz="UTC"),
) as dag:
task1 = DummyOperator(task_id="task1")
task2 = dummy_task(task1.output)
task1 >> task2
if __name__ == "__main__":
dag.test()
```
(cherry picked from commit 1b83f71)
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
amoghrajesh
approved these changes
May 29, 2025
kaxil
added a commit
that referenced
this pull request
Jun 3, 2025
…51199) When using `dag.test()` with deferred tasks, tasks that complete their trigger execution were incorrectly being set to `SUCCESS` state instead of `SCHEDULED` state. This prevented task resumption! Dag used to test: ```python from datetime import datetime, timedelta, timezone from typing import Any import pendulum from airflow.providers.standard.triggers.temporal import DateTimeTrigger from airflow.sdk import Context, task, BaseOperator, DAG class DummyOperator(BaseOperator): def execute(self, context: Context): self.defer( trigger=DateTimeTrigger( moment=datetime.now(timezone.utc) + timedelta(seconds=2), ), method_name="execute_complet", ) def execute_complet(self, context: Context, event: Any = None): assert event is not None return "test" @task def dummy_task(param): print("DEBUG") assert param == "test", "Parameter should be 'test'" with DAG( dag_id="example_debug", start_date=pendulum.datetime(2021, 1, 1, tz="UTC"), ) as dag: task1 = DummyOperator(task_id="task1") task2 = dummy_task(task1.output) task1 >> task2 if __name__ == "__main__": dag.test() ``` (cherry picked from commit 1b83f71) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
dag.test()with deferred tasks, tasks that complete their trigger execution were incorrectly being set toSUCCESSstate instead ofSCHEDULEDstate. This prevented task resumption!Dag used to test:
(cherry picked from commit 1b83f71)
Co-authored-by: Kaxil Naik kaxilnaik@gmail.com