Skip to content

Conversation

@atul-astronomer
Copy link
Contributor

Pinecone Cohere integration system test started failing after Cohere update to 5.13.4 v2 API in PR, this PR fixes this issue.

Testing:
Before
image

Fix
image

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 2, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@vatsrahul1001 vatsrahul1001 merged commit 22d7ba8 into apache:main Jun 2, 2025
63 of 64 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 2, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@vatsrahul1001 vatsrahul1001 deleted the fix-pinecone-cohere-system-test branch June 2, 2025 09:27
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
Co-authored-by: Atul Singh <atulsingh@Atuls-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants