Allow test migration to pytest 8.4.0 #51349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
ashb,
eladkal,
gopidesupavan,
jedcunningham,
o-nikolas and
potiuk
as code owners
boring-cyborg
bot
added
area:dev-tools
area:providers
provider:amazon
amoghrajesh
changed the title
potiuk
approved these changes
Jun 3, 2025
Member
|
Doc failures unrelated |
potiuk
added
the
backport-to-v3-1-test
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker be59eda v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 3, 2025
* Allow migration to pytest 8.4.0 * fixup! Allow migration to pytest 8.4.0 --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com> (cherry picked from commit be59eda)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 3, 2025
* Allow migration to pytest 8.4.0 * fixup! Allow migration to pytest 8.4.0 --------- (cherry picked from commit be59eda) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 3, 2025
* Allow migration to pytest 8.4.0 * fixup! Allow migration to pytest 8.4.0 --------- (cherry picked from commit be59eda) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
Jun 3, 2025
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
kaxil
added a commit
that referenced
this pull request
Jun 3, 2025
…#51306) (#51313) * Add Release notes for 3.0.2 * [v3-0-test] Allow test migration to pytest 8.4.0 (#51349) (#51359) * Allow migration to pytest 8.4.0 * fixup! Allow migration to pytest 8.4.0 --------- (cherry picked from commit be59eda) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> * [v3-0-test] Bump structlog min to 25.4.0 and handle tests accordingly (#51306) (cherry picked from commit be50a01) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> --------- Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 3, 2025
Follow-up after apache#51349 - merged after the fix for 8.4.0
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
kaxil
added a commit
that referenced
this pull request
Jun 3, 2025
…#51306) (#51313) * Add Release notes for 3.0.2 * [v3-0-test] Allow test migration to pytest 8.4.0 (#51349) (#51359) * Allow migration to pytest 8.4.0 * fixup! Allow migration to pytest 8.4.0 --------- (cherry picked from commit be59eda) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> * [v3-0-test] Bump structlog min to 25.4.0 and handle tests accordingly (#51306) (cherry picked from commit be50a01) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> --------- Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 3, 2025
Follow-up after apache#51349 - merged after the fix for 8.4.0
potiuk
added a commit
that referenced
this pull request
Jun 3, 2025
Follow-up after #51349 - merged after the fix for 8.4.0
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
kaxil
added a commit
that referenced
this pull request
Jun 3, 2025
…#51306) (#51313) * Add Release notes for 3.0.2 * [v3-0-test] Allow test migration to pytest 8.4.0 (#51349) (#51359) * Allow migration to pytest 8.4.0 * fixup! Allow migration to pytest 8.4.0 --------- (cherry picked from commit be59eda) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> * [v3-0-test] Bump structlog min to 25.4.0 and handle tests accordingly (#51306) (cherry picked from commit be50a01) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> --------- Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* Allow migration to pytest 8.4.0 * fixup! Allow migration to pytest 8.4.0 --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
Follow-up after apache#51349 - merged after the fix for 8.4.0
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 15, 2025
* Allow migration to pytest 8.4.0 * fixup! Allow migration to pytest 8.4.0 --------- (cherry picked from commit be59eda) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 15, 2025
* Allow migration to pytest 8.4.0 * fixup! Allow migration to pytest 8.4.0 --------- (cherry picked from commit be59eda) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
Jun 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #51337
Usage of async fixtures with pytest 8.4.0 has changed as mentioned here: https://github.com/pytest-dev/pytest/releases and is generally a problem for
autousefixtures.mock_awswas one such one of them leading to issues like:Moving the async decorator out of the fixture to keep it independent.
@mock_awsto the test class, the AWS mocking is active for everything inside the class, including when fixtures are being resolvez^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.