Reset table offset when DagFiltering changes #51694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
bbovenzi,
jscheffl,
ryanahamilton and
shubhamraj-git
as code owners
bbovenzi
approved these changes
Jun 13, 2025
pierrejeambrun
added
the
backport-to-v3-1-test
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 5de7cda v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
choo121600
pushed a commit
to choo121600/airflow
that referenced
this pull request
Jun 14, 2025
pierrejeambrun
added a commit
to astronomer/airflow
that referenced
this pull request
Jun 16, 2025
(cherry picked from commit 5de7cda)
pierrejeambrun
added a commit
to astronomer/airflow
that referenced
this pull request
Jun 16, 2025
(cherry picked from commit 5de7cda)
Member
Author
|
Manual backport pick #51795 |
pierrejeambrun
added a commit
that referenced
this pull request
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
offsetfrom the search param when we modify DagFilters.Otherwise this would wrongly display "no result found" on the front-end but just because we are requesting an offset that does not exist.
How to reproduce:
DagsFilterscomponent, see that 'no results' will appear (suposing there isn't 2 or 3 pages of result for that filtered query), but actually there are some results.Before
(clicking on "failed" when on page 3 will not reset the offset to 0, API will resturn no result for page 3 + failed state ending up in no result displayed in the UI).
After
(clicking on "failed" when on page 3 will reset the offset to 0 and display the proper result)
