-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Cleanup go.mod and go.sum #51900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup go.mod and go.sum #51900
Conversation
Removes unused dependencies in go mod and go sum, as well as adds a pre-commit to auto run mod tidy.
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that CI agrees.
|
Static check's are failing in js files which I haven't touched? Strange. Running it locally to check. |
|
Unrelated. We are having some issues in main |
Yep, that's an issue in main. |
|
Ah shoot, thanks for the pointer @vincbeck. Looks like something's broken in helm as well. |
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Removes unused dependencies in go mod and go sum, as well as adds a pre-commit to auto run mod tidy.
Removes unused dependencies in go mod
and go sum, as well as adds a pre-commit
to auto run mod tidy.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.