Skip to content

Conversation

@aritra24
Copy link
Collaborator

Removes unused dependencies in go mod
and go sum, as well as adds a pre-commit
to auto run mod tidy.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Removes unused dependencies in go mod
and go sum, as well as adds a pre-commit
to auto run mod tidy.
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that CI agrees.

@aritra24
Copy link
Collaborator Author

Static check's are failing in js files which I haven't touched? Strange. Running it locally to check.

@amoghrajesh
Copy link
Contributor

Unrelated. We are having some issues in main

@vincbeck
Copy link
Contributor

Static check's are failing in js files which I haven't touched? Strange. Running it locally to check. See #51890

Yep, that's an issue in main.

@aritra24
Copy link
Collaborator Author

Ah shoot, thanks for the pointer @vincbeck. Looks like something's broken in helm as well.

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amoghrajesh amoghrajesh merged commit 66ecce8 into apache:main Jun 20, 2025
98 checks passed
RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Jun 21, 2025
Removes unused dependencies in go mod
and go sum, as well as adds a pre-commit
to auto run mod tidy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants