When UI files change in PR we build CI image / run all static checks #52009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when only UI files changed (for example when dependabot bumped UI dependencies), the CI image was not built and only basic static checks were run - which did not show error when dependency upgrade caused different results when compiling ui assets
potiuk
requested review from
amoghrajesh,
ashb,
gopidesupavan and
jedcunningham
as code owners
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 22, 2025
…atic checks (apache#52009) Previously when only UI files changed (for example when dependabot bumped UI dependencies), the CI image was not built and only basic static checks were run - which did not show error when dependency upgrade caused different results when compiling ui assets (cherry picked from commit 294cd86) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
Jun 22, 2025
…atic checks (#52009) (#52012) Previously when only UI files changed (for example when dependabot bumped UI dependencies), the CI image was not built and only basic static checks were run - which did not show error when dependency upgrade caused different results when compiling ui assets (cherry picked from commit 294cd86)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when only UI files changed (for example when dependabot bumped UI dependencies), the CI image was not built and only basic static checks were run - which did not show error when dependency upgrade caused different results when compiling ui assets
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.