Skip to content

Conversation

@andrewhharmon
Copy link
Contributor

Jira

Description

  • Enhance the existing PostgresHook to allow for IAM authentication for RDS Postgres and Redshift.

Tests

  • My PR adds the following unit tests
    • test_get_conn()
    • test_get_conn_rds_iam_postgres()
    • test_get_conn_rds_iam_redshift

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

Enhance the exisitng PostgresHook to allow for IAM authentication for
RDS Postgres and Redshift.
@codecov-io
Copy link

Codecov Report

Merging #5223 into master will increase coverage by 0.01%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5223      +/-   ##
==========================================
+ Coverage   78.55%   78.56%   +0.01%     
==========================================
  Files         469      469              
  Lines       29983    30003      +20     
==========================================
+ Hits        23552    23571      +19     
- Misses       6431     6432       +1
Impacted Files Coverage Δ
airflow/hooks/postgres_hook.py 96.42% <95%> (+1.98%) ⬆️
airflow/models/taskinstance.py 92.42% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a70ed6...fc04c27. Read the comment docs.

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ashb ashb merged commit 373c945 into apache:master May 3, 2019
ashb pushed a commit that referenced this pull request May 3, 2019
Enhance the exisitng PostgresHook to allow for IAM authentication for
RDS Postgres and Redshift.
potiuk pushed a commit that referenced this pull request May 4, 2019
Enhance the exisitng PostgresHook to allow for IAM authentication for
RDS Postgres and Redshift.
@mik-laj
Copy link
Member

mik-laj commented May 7, 2019

@andrewhharmon
Copy link
Contributor Author

@mik-laj whats the best way to do that? will i just need to create a new PR? Can it reference the same JIRA?

@mik-laj
Copy link
Member

mik-laj commented May 7, 2019

@mik-laj You do not need to refer to the Jira ticket. Changes to the documentation can be made using [AIRFLOW-XXX]. If you want to make a change then you need to create a new PR, because it has already been closed.

andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
Enhance the exisitng PostgresHook to allow for IAM authentication for
RDS Postgres and Redshift.
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
Enhance the exisitng PostgresHook to allow for IAM authentication for
RDS Postgres and Redshift.
dharamsk pushed a commit to postmates/airflow that referenced this pull request Aug 8, 2019
Enhance the exisitng PostgresHook to allow for IAM authentication for
RDS Postgres and Redshift.
@ryw ryw deleted the postgres_iam_auth branch August 18, 2019 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants