[v3-0-test] Python versions in shell params are strings (#52306) #52309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The versions were "floats" and it accidentally worked because they were coerced to strings, but with 3.10 it will be coerced to the "3.1" string. (cherry picked from commit 1c0c01d) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
potiuk
requested review from
amoghrajesh,
ashb,
gopidesupavan,
jedcunningham and
potiuk
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The versions were "floats" and it accidentally worked because
they were coerced to strings, but with 3.10 it will be coerced to
the "3.1" string.
(cherry picked from commit 1c0c01d)
Co-authored-by: Jarek Potiuk jarek@potiuk.com