Skip to content

Conversation

@gbloisi-openaire
Copy link
Contributor

Users may want to have their logs on a volume that includes other things and as such want to use a subPath on the Volume Mount. This is similar to how the gitSync and dags Volume Mounts are setup (see PR 22323 )


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 27, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jun 27, 2025
@gbloisi-openaire
Copy link
Contributor Author

Anyone could check?
Even though many lines have been added the change is relatively simple as it replicates the pattern for subPath support in other volumes. It has been tested in a deployment where logging goes to a shared nfs volume.

@potiuk
Copy link
Member

potiuk commented Aug 1, 2025

Can you add a helm-test for that one?

@gbloisi-openaire
Copy link
Contributor Author

@potiuk I just added tests using as model the ones written for #22323 keeping in consideration that now there is a different rending depending on airflow version.

@potiuk
Copy link
Member

potiuk commented Aug 4, 2025

Let's see if CI agrees

@potiuk potiuk merged commit cb7f400 into apache:main Aug 5, 2025
72 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 5, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@eladkal eladkal added this to the Airflow Helm Chart 1.19.0 milestone Aug 5, 2025
Nataneljpwd pushed a commit to Asquator/airflow that referenced this pull request Aug 5, 2025
* enable optional ``subPath`` for logs volume mount

* Add tests for optional ``subPath`` for logs volume mount

* Fix identation
HsiuChuanHsu pushed a commit to HsiuChuanHsu/airflow that referenced this pull request Aug 5, 2025
* enable optional ``subPath`` for logs volume mount

* Add tests for optional ``subPath`` for logs volume mount

* Fix identation
ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 7, 2025
* enable optional ``subPath`` for logs volume mount

* Add tests for optional ``subPath`` for logs volume mount

* Fix identation
fweilun pushed a commit to fweilun/airflow that referenced this pull request Aug 11, 2025
* enable optional ``subPath`` for logs volume mount

* Add tests for optional ``subPath`` for logs volume mount

* Fix identation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants