-
Notifications
You must be signed in to change notification settings - Fork 16.4k
enable optional subPath for logs volume mount #52350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Anyone could check? |
|
Can you add a helm-test for that one? |
|
Let's see if CI agrees |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* enable optional ``subPath`` for logs volume mount * Add tests for optional ``subPath`` for logs volume mount * Fix identation
* enable optional ``subPath`` for logs volume mount * Add tests for optional ``subPath`` for logs volume mount * Fix identation
* enable optional ``subPath`` for logs volume mount * Add tests for optional ``subPath`` for logs volume mount * Fix identation
* enable optional ``subPath`` for logs volume mount * Add tests for optional ``subPath`` for logs volume mount * Fix identation
Users may want to have their logs on a volume that includes other things and as such want to use a subPath on the Volume Mount. This is similar to how the gitSync and dags Volume Mounts are setup (see PR 22323 )
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.