Move costraint check to breeze #52696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
amoghrajesh,
ashb,
gopidesupavan and
jedcunningham
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
potiuk
added
the
upgrade to newer dependencies
potiuk
force-pushed
the
move-constraints-check-to-breeze
branch
from
00c1937 to
02a1099
Compare
potiuk
force-pushed
the
move-constraints-check-to-breeze
branch
from
02a1099 to
4e74276
Compare
Member
Author
|
Also this one will fix |
We started to copy more and more code from breeze utils to the constraint generation script - including using github token for pulling constraints files, reading python version, running command etc - so it's now the time to move the constraint check to become a regular breeze command and import utils from breeze utils. We are running the command in the CI image which has both advantages and disadvantages - it's a bit slower and requires the CI image to be built for the right Python version but it makes sure that the outputs are reproducible across different OS's and system libraries.
potiuk
force-pushed
the
move-constraints-check-to-breeze
branch
from
4e74276 to
49f39f4
Compare
eladkal
approved these changes
Jul 2, 2025
gopidesupavan
approved these changes
Jul 2, 2025
Member
Author
|
Really nice reports ! |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
We started to copy more and more code from breeze utils to the constraint generation script - including using github token for pulling constraints files, reading python version, running command etc - so it's now the time to move the constraint check to become a regular breeze command and import utils from breeze utils. We are running the command in the CI image which has both advantages and disadvantages - it's a bit slower and requires the CI image to be built for the right Python version but it makes sure that the outputs are reproducible across different OS's and system libraries. (cherry picked from commit 906da03) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Backport successfully created: v3-0-test
|
potiuk
added a commit
that referenced
this pull request
Jul 2, 2025
We started to copy more and more code from breeze utils to the constraint generation script - including using github token for pulling constraints files, reading python version, running command etc - so it's now the time to move the constraint check to become a regular breeze command and import utils from breeze utils. We are running the command in the CI image which has both advantages and disadvantages - it's a bit slower and requires the CI image to be built for the right Python version but it makes sure that the outputs are reproducible across different OS's and system libraries. (cherry picked from commit 906da03) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
kaxil
added a commit
that referenced
this pull request
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started to copy more and more code from breeze utils to the constraint generation script - including using github token for pulling constraints files, reading python version, running command etc - so it's now the time to move the constraint check to become a regular breeze command and import utils from breeze utils.
We are running the command in the CI image which has both advantages and disadvantages - it's a bit slower and requires the CI image to be built for the right Python version but it makes sure that the outputs are reproducible across different OS's and system libraries.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.