Run trigger expansion logic only when start_from_trigger is True #52861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsrahul1001
changed the title
vatsrahul1001
changed the title
vatsrahul1001
changed the title
kaxil
added
the
backport-to-v3-1-test
kaxil
approved these changes
Jul 4, 2025
2 tasks
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jul 4, 2025
…r`` is True (apache#52861) (cherry picked from commit f20b720) Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com> closes: apache#52845
kaxil
pushed a commit
that referenced
this pull request
Jul 4, 2025
kaxil
pushed a commit
that referenced
this pull request
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a logic issue introduced in #48006. That PR was meant to prevent mapped tasks from starting directly from the triggerer, but it had a misplaced return False outside the if block, so it always returned early. At the time, the logic issue was hidden because of indentation.
Later, #51701 fixed the indentation, which made the earlier bug more obvious.
closes :#52845
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.